added segment_traits_by_field and segment_identifiers_by_field in ups…#3822
Open
monutwilio wants to merge 6 commits into
Open
added segment_traits_by_field and segment_identifiers_by_field in ups…#3822monutwilio wants to merge 6 commits into
monutwilio wants to merge 6 commits into
Conversation
…ertProfile Memora Sync
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two internal (hidden) mapping fields to the Memora Upsert Profile action so Segment’s control plane can capture per-field usage of Segment trait and identifier directives for enrichment / id_sync wiring.
Changes:
- Introduces
segment_traits_by_fieldas an internal object field to record referenced Segment trait names by stored field key. - Introduces
segment_identifiers_by_fieldas an internal object field to record referenced Segment identifier names by stored field key.
…d types Documents that both fields are used exclusively by the Segment control plane (actions-memora-internal destination) for the Conversation Memory Sync feature, and explains why they are marked unsafe_hidden. Also includes generated-types updates that were missing from the previous commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Verifies that the unsafe_hidden control-plane metadata fields are never forwarded in the outbound Bulk upsert request body. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nk1107
previously approved these changes
Jun 4, 2026
… only These fields are exclusively used by the Segment control plane for the Conversation Memory Sync feature and have no place in the public memora destination. memora-internal now overrides upsertProfile to spread the base action fields and append the two unsafe_hidden fields. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test was using the base memora destination where the fields are not declared, so the framework stripped them trivially. Moved to memora-internal where segment_traits_by_field and segment_identifiers_by_field are declared, making the assertion meaningful. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds nockIntercepted flag and response assertions so the test fails meaningfully if the HTTP interceptor is never hit, not just on body content. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
varadarajan-tw
approved these changes
Jun 4, 2026
varadarajan-tw
approved these changes
Jun 15, 2026
nk1107
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://twilio-engineering.atlassian.net/browse/STRATCONN-6826
Testing
Manual testing details is in control-plane PR
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example